Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wildcards in file exclude config #640

Merged
merged 4 commits into from
Aug 25, 2016

Conversation

pcantrell
Copy link
Collaborator

The exclude config option is clearly intended to support wildcards, but they weren’t working because:

  • the crucial call to fnmatch? passed the arguments in the wrong order and
  • one of them was a Pathname instead of a string.

This PR makes wildcard excludes work as expected. The corresponding specs update adds a regression test for wildcards.

The specs were not passing when I checked them out. I just regenerated them to match what jazzy was producing without further investigation. Here’s what changed.

@pcantrell
Copy link
Collaborator Author

Once this is merged, somebody should check whether it helps with #619.

@pcantrell
Copy link
Collaborator Author

YOLOOOOO

@pcantrell pcantrell merged commit 9f7ee00 into realm:master Aug 25, 2016
@pcantrell pcantrell deleted the fix-exclude-pattern-matching branch August 25, 2016 00:19
@pigeondotdev pigeondotdev modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants